[2/4] Supermicro redfish methods #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelrebel
changed the title
Comment on lines
+192
to
+207
| func (c *Client) PowerStateGet(ctx context.Context) (state string, err error) { | ||
| if c.serviceClient == nil || c.serviceClient.redfish == nil { | ||
| return "", errors.Wrap(bmclibErrs.ErrLoginFailed, "client not initialized") | ||
| } | ||
|
|
||
| return c.serviceClient.redfish.SystemPowerStatus(ctx) | ||
| } | ||
|
|
||
| // PowerSet sets the power state of a server | ||
| func (c *Client) PowerSet(ctx context.Context, state string) (ok bool, err error) { | ||
| if c.serviceClient == nil || c.serviceClient.redfish == nil { | ||
| return false, errors.Wrap(bmclibErrs.ErrLoginFailed, "client not initialized") | ||
| } | ||
|
|
||
| return c.serviceClient.redfish.PowerSet(ctx, state) | ||
| } |
There was a problem hiding this comment.
Should the state for these methods be a constant with a specific type, something like PowerState?
There was a problem hiding this comment.
yep thats the plan, although since this will affect all providers and it changes the interface, it needs to be done separately
…thod should be generic
…rSet(), PowerStateGet() methods
…oadedAndInitiate(), FirmwareInstallStatus() methods
DoctorVin
approved these changes
Nov 28, 2023
coffeefreak101
approved these changes
Nov 28, 2023
[4/4] Redfish dell
[3/4] redfish/GetBiosConfiguration: move tests and fixtures
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
Checklist